Repository navigation
Respect the provider OAuth refresh window before review - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trusted runner refreshes whenever an OAuth token has less than 25 minutes remaining, but the provider can forbid renewal until a later
earliest_refresh_at. Live acceptance reached the credential stage before that timestamp, andOAuth.refreshintentionally rejects premature calls. The unclassified failure recorded a safe COMMENT and correctly failed the review job.Wait until the provider’s eligibility timestamp under the existing exclusive session lease, bounded to the 25-minute renewal window. Only then perform the existing official refresh and durably CAS-persist rotation before inference. Do not reconnect, copy tokens, bypass expiry, change endpoints or fall back to paid API billing. Increase the review job cap from 35 to 50 minutes to include that provider-mandated wait and bounded inference; no new permissions or credential access.
Validation: full Node 24 check (196 tests), virtual-clock proof of no early continuation, immediate eligible continuation and bounded/invalid timestamps; workflow budget assertion. Full CI includes actual Codex/Docker isolation. Runner/workflow change requires coordinated pins to this PR’s actual merge SHA before rollout. Global merging and deferred website flags remain disabled.